Only automatically link snippets to product libraries #5929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snippets illustrate how to use a package's products by design, so they shouldn't link to library targets that aren't exported as products. If snippets link to all library targets, one negative result would be inadvertently linking to test support libraries, which could cause failures due to automatic linking of `@rpath/libXCTestSwiftSupport.dylib`, a library not available to snippets at runtime. rdar://102746374
bitjammer
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
neonichu
approved these changes
Nov 29, 2022
bitjammer
deleted the
acgarland/rdar-102746374-snippets-only-link-product-libraries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippets illustrate how to use a package's products by design, so they shouldn't link to library targets that aren't exported as products.
If snippets link to all library targets, one negative result would be inadvertently linking to test support libraries, which could cause failures due to automatic linking of
@rpath/libXCTestSwiftSupport.dylib, a library not available to snippets at runtime.rdar://102746374