[PackageLoading] Fix public declaration on a property. #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The way this was being done currently is actually just relying on a compiler bug, and fails in release builds (see SR-2315). (cherry picked from commit 5b61a83)
|
/cc @tkremenek @rballard this is important to have on the release branch as it was preventing creating release builds of SwiftPM. I've tested this locally, going and ahead and merging it for now to unblock other work. Let me know if you have any questions. |
|
@ddunbar Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug, and fails in release builds (see SR-2315).
(cherry picked from commit 5b61a83)