Fix two small issues with handling of plugin triples #5945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
FranzBusch
approved these changes
Dec 5, 2022
tomerd
reviewed
Dec 5, 2022
tomerd
approved these changes
Dec 5, 2022
|
possible to add a test? |
|
Not sure what is going in the Windows build: cc @compnerd |
|
BTW, it looks like SourceKit-LSP itself is not running Windows for its CI, that seems wrong. Either it should be removed from SwiftPM's preset as well or it should be running Windows builds on its own PRs. cc @shahmishal |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test windows |
neonichu
force-pushed
the
fix-plugin-triples
branch
from
2cd9d77 to
befa20a
Compare
|
@swift-ci please smoke test |
|
Ah yes, |
- We were not stringently using version-less triples in all comparisons - We were not merging the supported triples of all executable info entries into the final `toolNamesToTriples` which could lead to incorrect errors about unsupported platforms rdar://101096803
neonichu
force-pushed
the
fix-plugin-triples
branch
from
befa20a to
4497e77
Compare
|
@swift-ci please smoke test |
neonichu
added a commit
that referenced
this pull request
Dec 9, 2022
Until now, we had two almost identical code paths for processing accessible tools and e.g. the command plugin code didn't get the fixes from #5945. This PR consolidates the two and also fixes a bug regarding executable path handling of vended tools.
neonichu
added a commit
that referenced
this pull request
Dec 15, 2022
Until now, we had two almost identical code paths for processing accessible tools and e.g. the command plugin code didn't get the fixes from #5945. This PR consolidates the two and also fixes a bug regarding executable path handling of vended tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolNamesToTripleswhich could lead to incorrect errors about unsupported platformsrdar://101096803