Skip to content

Stop build if there were build-tool plugin failures #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Dec 5, 2022

rdar://102989296

@neonichu neonichu self-assigned this Dec 5, 2022
@neonichu neonichu requested a review from elsh as a code owner December 5, 2022 19:01
@neonichu
Copy link
Contributor Author

neonichu commented Dec 5, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 5, 2022

PackageToolTests.testBuildToolPluginFailure needs an update (it is not failing for macOS on CI since we can't run the plugin tests there because of lack of concurrency support).

@neonichu neonichu force-pushed the stop-build-on-plugin-errors branch from 19047d1 to 30c4a37 Compare December 5, 2022 21:14
@neonichu
Copy link
Contributor Author

neonichu commented Dec 5, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 6, 2022

@swift-ci please smoke test linux

1 similar comment
@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2022

@swift-ci please smoke test linux

@neonichu neonichu merged commit 848924e into main Dec 8, 2022
@neonichu neonichu deleted the stop-build-on-plugin-errors branch December 8, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants