PackageModel: fix Destination.init default arguments
#5953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extraCPPFlags` previously had a default value, but after renaming to `extraCXXFlags` in 75877ea this default value was lost. Let's restore it for compatibility with libSwiftPM clients.
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
|
@neonichu I'm seeing this error again you mentioned recently, do you know if this is sporadic or is there a way to make it go away or work around it? |
|
@swift-ci please test Windows |
No, it's consistent and appears to be an issue with recent nightly toolchains where XCTest is built in a way that requires explicitly setting up library search paths at runtime. Trying to land a workaround here: #5952 |
neonichu
approved these changes
Dec 7, 2022
|
@swift-ci smoke test Linux |
|
@swift-ci smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
extraCPPFlagspreviously had a default value, but after renaming toextraCXXFlagsin 75877ea this default value was lost. Let's restore it for compatibility with libSwiftPM clients.Modifications:
extraCPPFlagsargument of deprecatedDestination.initnow has a default argument, like it had before 75877ea.Result:
Code relying on libSwiftPM now can rely on the default argument, as it did before.