Add async-friendly actor HTTPClient
#6022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
tomerd
reviewed
Jan 6, 2023
| @@ -28,6 +28,19 @@ public struct URLSessionHTTPClient { | |||
| self.downloadTaskManager = DownloadTaskManager(configuration: configuration) | |||
| } | |||
|
|
|||
| @available(macOS 12, *) | |||
| public func execute( | |||
There was a problem hiding this comment.
couple of things:
- lets add a test that puts some concurrent load on this? there is a similar one already but would be nice to have one that tests the threading across async boundries
- iirc @neonichu ran into some trouble introducing async APIs since some of the CI / toolchain build nodes did not have the backward support libraries. need to make sure that is addressed so we can finally make use of async APIs in SwiftPM
There was a problem hiding this comment.
I've added tests that are basically asyncified copies of existing non-async tests for HTTPClient. Did you have something specific in mind for testing threading across async boundaries?
|
@swift-ci smoke test |
MaxDesiatov
force-pushed
the
maxd/httpclient-async-execute
branch
from
f791384 to
8de3549
Compare
tomerd
approved these changes
Jan 10, 2023
|
@swift-ci smoke test |
tomerd
reviewed
Jan 11, 2023
Tests/PackageCollectionsTests/JSONPackageCollectionProviderTests.swift
Outdated
Show resolved
Hide resolved
tomerd
reviewed
Jan 11, 2023
tomerd
reviewed
Jan 11, 2023
tomerd
suggested changes
Jan 11, 2023
MaxDesiatov
force-pushed
the
maxd/httpclient-async-execute
branch
from
60bde3f to
f5925b7
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
6 similar comments
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
MaxDesiatov
force-pushed
the
maxd/httpclient-async-execute
branch
from
47191c8 to
219ede1
Compare
|
@swift-ci smoke test |
tomerd
approved these changes
Jan 31, 2023
|
@swift-ci smoke test |
|
@swift-ci test Windows platform |
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For making HTTP requests in
asynccontext, eitherHTTPClientor its replacement need to exposeasyncfunctions.Modifications:
Existing
HTTPClientmakes strong assumptions about its concurrency behavior, as it exposes Dispatch types in its API. For that reason it was renamed toLegacyHTTPClient. NewHTTPClientcan use the sameURLSessionHTTPClientunderlying implementation thatLegacyHTTPClientuses.Additionally, moved
HTTPClientHeaders,HTTPClientRequest, andHTTPClientResponseto separate files for easier maintenance.Depends on #6058 and #6075.
Result:
HTTPClientcan now be used inasynccontext. It's not used anywhere in this PR yet, so this is technically NFC.