[5.8] PackageModel: partially address #5719 #6117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle `-use-ld=` from the configuration in the selection of the librarian. We do not honour the `-Xmanifest` or `-Xswiftc` flags being passed on the command line rather than the plist as we cannot pre-compute the flags.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@tomerd - this resolves a regression from 5.7 where you cannot use SPM outside of VsDevEnv. |
|
@swift-ci please smoke test |
tomerd
changed the title
|
okay to merge if this is only impacting windows. @compnerd please confirm? |
|
Yes, this is a windows only fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
-use-ld=from the configuration in the selection of the librarian. We do not honour the-Xmanifestor-Xswiftcflags being passed on the command line rather than the plist as we cannot pre-compute the flags.