update registry publishing #6146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
yim-lee
and removed request for
neonichu,
elsh and
abertelrud
|
@swift-ci smoke test |
yim-lee
reviewed
Feb 10, 2023
|
@swift-ci smoke test |
tomerd
force-pushed
the
feature/registry-publish-6
branch
from
24e5d8a to
8eae339
Compare
|
@swift-ci smoke test |
|
@yim-lee updated per our discussion |
yim-lee
reviewed
Feb 14, 2023
motivation: update based on recent spec changes: * do not request server requirements, deduce configuration based on use provided flags * fix issues in publishing logic per testing * simplify metadata handling
tomerd
force-pushed
the
feature/registry-publish-6
branch
from
8eae339 to
e8196d3
Compare
|
@swift-ci smoke test |
|
@yim-lee updated |
yim-lee
approved these changes
Feb 15, 2023
| observabilityScope: swiftTool.observabilityScope | ||
| ) | ||
| } | ||
|
|
||
| // step 4: publish the package | ||
| guard !self.dryRun else { | ||
| print( | ||
| "\(packageIdentity)@\(packageVersion) was successfully prepared for publishing but was not published due to dry run flag. artifacts available at '\(workingDirectory)'." |
There was a problem hiding this comment.
Suggested change
| "\(packageIdentity)@\(packageVersion) was successfully prepared for publishing but was not published due to dry run flag. artifacts available at '\(workingDirectory)'." | |
| "\(packageIdentity)@\(packageVersion) was successfully prepared for publishing but was not published due to dry run flag. Artifacts available at '\(workingDirectory)'." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: update based on recent spec
changes: