[5.8][Registry] Make 'Content-Version' optional for archive and manifest download API #6156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownload API Motivation: The 'Content-Version' header is required in all registry server responses to indicate API version. However, it shouldn't be required for responses that don't/can't change, such as the download archive and fetch package manifest endpoints. This may also cause problems for registry that have these files hosted elsewhere, because they may not have full control over response headers. Modifications: - Modify registry API spec to make 'Content-Version' optional for the said endpoints - Adjust `RegistryClient` rdar://105415468
yim-lee
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
neonichu
approved these changes
Feb 14, 2023
|
@swift-ci please smoke test Windows |
tomerd
approved these changes
Feb 14, 2023
|
Seeing this in the Windows build: @shahmishal How do we get 5.8 CI going for Windows? |
|
windows failure does not seem to be related, okay to merge to not block progress |
|
@compnerd Do you know what's going on with this failure? |
|
@shahmishal - looks like an infrastructure issue? It seems that it didn't do a clean build? |
|
@yim-lee since this is a spot change that is not platform specific, I think we dont need to hold on the Windows issue which is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking #6153 to 5.8.
The API spec changes are the same, but the implementation is different.
Motivation:
The 'Content-Version' header is required in all registry server responses to indicate API version. However, it shouldn't be required for responses that don't/can't change, such as the download archive and fetch package manifest endpoints. This may also cause problems for registry that have these files hosted elsewhere, because they may not have full control over response headers.
Modifications:
RegistryClientrdar://105415468