Define SWIFT_PACKAGE in generated Xcode projects #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -288,6 +288,9 @@ extension Module { | |||
| // At the moment, set the Swift version to 3 (we will need to make this dynamic), but for now this is necessary. | |||
| buildSettings["SWIFT_VERSION"] = "3.0" | |||
|
|
|||
| // Defined for regular `swift build` instantiations, so also should be defined here. | |||
| buildSettings["OTHER_SWIFT_FLAGS"] = "-DSWIFT_PACKAGE" | |||
There was a problem hiding this comment.
I think this should use SWIFT_ACTIVE_COMPILATION_CONDITIONS instead of OTHER_SWIFT_FLAGS, otherwise LGTM.
There was a problem hiding this comment.
I was worried that was Xcode 8 only, but maybe that's fine? Will update.
This mimics the behavior in standard swift-build instantiations.
|
Cool, thanks! @swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics the behavior in standard swift-build instantiations.
Refs mxcl/PromiseKit#516