Skip to content

Hide dump-pif command. #6164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Hide dump-pif command. #6164

merged 2 commits into from
Feb 21, 2023

Conversation

heckj
Copy link
Member

@heckj heckj commented Feb 16, 2023

Hides the dump-pif command from generated help on swift package

Motivation:

Clean up the UI/CLI experience.

Modifications:

Hides the dump-pif command from --help or the default response from swift package with no further subcommands.

Result:

swift package CLI is a bit cleaner

@neonichu
Copy link
Contributor

Thanks for your PR, but I think dump-pif should actually be hidden, similarly to --build-system xcode as these are considered experimental features. cc @tomerd

@heckj
Copy link
Member Author

heckj commented Feb 21, 2023

@neonichu Ah - I'll update it to be hidden then, that totally works for me. I wasn't sure about the status - I could tell it was a debugging tool for the XCBuild integration work, and mostly just wanted the user experience of exploring what "could be done" to be cleaner.

@heckj heckj force-pushed the explain-pif-command branch from ce35679 to fef6e81 Compare February 21, 2023 18:00
@heckj heckj changed the title Add abstract to explain PIF and what dump-pif does. Hide dump-pif command. Feb 21, 2023
@tomerd tomerd enabled auto-merge (squash) February 21, 2023 20:20
@tomerd
Copy link
Contributor

tomerd commented Feb 21, 2023

@swift-ci smoke test

@tomerd tomerd merged commit 208b836 into swiftlang:main Feb 21, 2023
@heckj heckj deleted the explain-pif-command branch February 22, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants