Add headerVisibility support on PIFBuilder #6167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@neonichu Hi! 👋 What do you think about this patch? |
|
@swift-ci please smoke test |
|
Thanks, @giginet, looks good to me. I'm going to run a toolchain build for this, though, since the smoke tests don't actually exercise a full build of SwiftPM using |
|
Toolchain build passed. |
|
@swift-ci please smoke test windows |
neonichu
approved these changes
Mar 8, 2023
giginet
added a commit
to giginet/swift-package-manager
that referenced
this pull request
Mar 29, 2023
* Add headerVisibility for PIF builders * Add test for encoding header phase
giginet
added a commit
to giginet/swift-package-manager
that referenced
this pull request
Mar 29, 2023
* Add headerVisibility for PIF builders * Add test for encoding header phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PIF has headerVisibility for each BuildFile, however, we can't add headerVisibility in any way.
Modifications:
headerVisibilityheaderVisibilityResult: