Skip to content

Do not crash on duplicated product names #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

Do not crash on duplicated product names #6245

merged 1 commit into from
Mar 20, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Mar 8, 2023

Instead we need to raise an error if we end up in that situation.

rdar://106432785

@neonichu neonichu self-assigned this Mar 8, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Mar 8, 2023

@swift-ci please smoke test

MaxDesiatov
MaxDesiatov reviewed Mar 8, 2023
View reviewed changes
@neonichu
Do not crash on duplicated product names
5d61ea5 
Instead we need to raise an error if we end up in that situation.

rdar://106432785
@neonichu neonichu force-pushed the do-not-crash-on-duplicated-products branch from 67cb4a5 to 5d61ea5 Compare March 20, 2023 20:09
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) March 20, 2023 20:09
@MaxDesiatov

This comment was marked as duplicate.

Sign in to view
1 similar comment
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test macOS

@etcwilde
Copy link
Member

etcwilde commented Mar 20, 2023 •
edited
Loading

Windows failure:

fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Found related pull requests: []

Hmm, looks like update-checkout is tipping over again.

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@neonichu neonichu merged commit c5531b6 into main Mar 20, 2023
@compnerd compnerd deleted the do-not-crash-on-duplicated-products branch March 26, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @MaxDesiatov @etcwilde