Skip to content

Allow clients to programmatically accept an identity change #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Allow clients to programmatically accept an identity change #6248

merged 1 commit into from
Mar 21, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Mar 9, 2023

This will allow clients to take the information from specific registry error cases and programmatically accept them as valid. This can be useful if a client wants to offer a way for users to accept an allowed identity change.

@neonichu neonichu requested a review from yim-lee March 9, 2023 01:37
@neonichu neonichu self-assigned this Mar 9, 2023
yim-lee
yim-lee reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proposed Workspace API looks reasonable, but how we wire it up requires more thinking IMO. Maybe we just define the Workspace API for now that does nothing and worry about implementation details later?

yim-lee
yim-lee reviewed Mar 9, 2023
View reviewed changes
yim-lee
yim-lee reviewed Mar 9, 2023
View reviewed changes
yim-lee
yim-lee reviewed Mar 10, 2023
View reviewed changes
@neonichu neonichu force-pushed the accept-identity-change branch from fb0f042 to 4963854 Compare March 17, 2023 00:16
@neonichu neonichu marked this pull request as ready for review March 17, 2023 00:16
@neonichu neonichu requested a review from abertelrud as a code owner March 17, 2023 00:16
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

yim-lee
yim-lee reviewed Mar 17, 2023
View reviewed changes
@neonichu
Allow clients to programmatically accept an identity change
9640e85 
This will allow clients to take the information from specific registry error cases and programmatically accept them as valid. This can be useful if a client wants to offer a way for users to accept an allowed identity change.
@neonichu neonichu force-pushed the accept-identity-change branch from 4963854 to 9640e85 Compare March 20, 2023 19:15
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) March 20, 2023 19:18
@neonichu
Copy link
Contributor Author

So Windows is now required but we have to manually start it? Could we add it to the generic @swift-ci please smoke test trigger somehow? cc @shahmishal @compnerd

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@neonichu neonichu merged commit 7b37649 into main Mar 21, 2023
@compnerd compnerd deleted the accept-identity-change branch March 26, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd left review comments

@yim-lee yim-lee yim-lee approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @tomerd @yim-lee