[PackageBuilder] Error on invalid manifest config #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package = PackageDescription.Package(name: "pkg", providers: [.Brew("foo")]) | ||
|
|
||
| PackageBuilderTester(package, in: fs) { result in | ||
| result.checkDiagnostic("invalid configuration in pkg: providers should only be used with a System Module Package") |
There was a problem hiding this comment.
we should use package in error messages, not a shortcut.
There was a problem hiding this comment.
thats the package name in this test case
invalid configuration in <package_name>: ...
should I make it
invalid configuration in package <package_name>: ...
There was a problem hiding this comment.
oh! One general practice I try and follow is put literal stuff in quotes to clarify words versus references: invalid configuration in 'pkg': or so.
|
One comment, otherwise LGTM. |
Error out when pkgconfig and providers are used by non system module packages. - SR-2533 - <rdar://problem/28118479> SR-2533 Error out when pkgconfig and providers are used by non system module packages
|
Tested locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error out when pkgconfig and providers are used by non
system module packages.
providers are used by non system module packages