Improve error handling for 'package-registry login' command #6286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
cc @Palleas |
tomerd
approved these changes
Mar 15, 2023
yim-lee
force-pushed
the
better-login-error
branch
from
6ecadd3 to
dd096eb
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@swift-ci pleases test Windows platform |
1 similar comment
|
@swift-ci pleases test Windows platform |
|
@swift-ci pleases smoke test |
1 similar comment
|
@swift-ci pleases smoke test |
|
@swift-ci please smoke test |
|
@swift-ci pleases test Windows platform |
Motivation: When running `login` with `--netrc` and `--netrc-file` options and the custom netrc file doesn't exist, the command fails immediately with file not found error: ``` swift-package-registry --netrc --netrc-file ./netrc-test login Error: Did not find netrc file at /Users/appleseed/netrc-test. ``` Which can be confusing. Modifications: Rearrange logic so that we initialize `AuthorizationProvider` first thing and display better error messages to user. ``` Error: credential store is invalid: did not find netrc file at /Users/appleseed/netrc-test ```
yim-lee
force-pushed
the
better-login-error
branch
from
63e1592 to
5fce1a6
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
tomerd
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running
loginwith--netrcand--netrc-fileoptions and the custom netrc file doesn't exist, the command fails immediately with file not found error:Which can be confusing.
Modifications:
Rearrange logic so that we initialize
AuthorizationProviderfirst thing and display better error messages to user.