Skip to content

Update to swift-certificates 0.4.0 #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2023
Merged

Update to swift-certificates 0.4.0 #6316

merged 3 commits into from
Apr 20, 2023

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Mar 23, 2023 •
edited
Loading

  • Adjust code
  • Re-enable SigningTests.testCMSCheckCertificateRevocationStatus
  • Implement SignatureProvider.extractSigningEntity
  • Rework disabling of certificate expiry check
  • Update OCSPPolicy usage

@yim-lee yim-lee marked this pull request as draft March 23, 2023 04:29
@yim-lee yim-lee changed the title Update to latest swift-certificates [DNM] Update to latest swift-certificates Mar 23, 2023
yim-lee
yim-lee commented Mar 23, 2023
View reviewed changes
@yim-lee yim-lee mentioned this pull request Mar 23, 2023
Closed
@yim-lee yim-lee force-pushed the swift-certificates-next branch 3 times, most recently from 5f1ee20 to 1982f4c Compare March 28, 2023 00:15
@yim-lee yim-lee mentioned this pull request Mar 28, 2023
Merged
@yim-lee yim-lee force-pushed the swift-certificates-next branch from 9a1cffe to 311730d Compare March 31, 2023 16:48
@yim-lee yim-lee mentioned this pull request Mar 31, 2023
Merged
@yim-lee yim-lee force-pushed the swift-certificates-next branch 2 times, most recently from 8d58894 to de9cbd0 Compare April 13, 2023 22:59
yim-lee
yim-lee commented Apr 13, 2023
View reviewed changes
Sources/PackageSigning/SignatureProvider.swift
@@ -310,6 +308,66 @@ struct CMSSignatureProvider: SignatureProviderProtocol {
throw SigningError.unableToValidateSignature("\(error)")
}
}

func extractSigningEntity(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neonichu Implemented extractSigningEntity as part of this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@yim-lee yim-lee force-pushed the swift-certificates-next branch 2 times, most recently from b2ee4a5 to e462768 Compare April 14, 2023 16:58
@yim-lee yim-lee changed the title [DNM] Update to latest swift-certificates [DNM] Update to swift-certificates 0.3.0 Apr 14, 2023
@yim-lee yim-lee changed the title [DNM] Update to swift-certificates 0.3.0 Update to swift-certificates 0.3.0 Apr 17, 2023
@yim-lee yim-lee marked this pull request as ready for review April 17, 2023 16:23
@yim-lee yim-lee requested a review from MaxDesiatov as a code owner April 17, 2023 16:23
@yim-lee yim-lee force-pushed the swift-certificates-next branch from e462768 to 4d9e8ab Compare April 17, 2023 16:29
@yim-lee yim-lee mentioned this pull request Apr 17, 2023
Merged
@yim-lee yim-lee mentioned this pull request Apr 18, 2023
Merged
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 18, 2023

macOS cmake build failing with:

/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/swift-certificates/Sources/X509/CertificatePrivateKey.swift:158:32: error: cannot find type 'SecureEnclave' in scope
        case secureEnclaveP256(SecureEnclave.P256.Signing.PrivateKey)
                               ^~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

Trying to fix with apple/swift-certificates#67, which means we will need another swift-certificates release.

MaxDesiatov
MaxDesiatov reviewed Apr 18, 2023
View reviewed changes
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 18, 2023

Update: to fix cmake build for macOS requires new swift-crypto version (apple/swift-crypto#177) and swift-certificates (apple/swift-certificates#68).

yim-lee added 2 commits April 19, 2023 08:42
@yim-lee
Update to swift-certificates 0.3.0
9be812d 
- Adjust code
- Re-enable `SigningTests.testCMSCheckCertificateRevocationStatus`
- Implement `SignatureProvider.extractSigningEntity`
- Rework disabling of certificate expiry check
- Update `OCSPPolicy` usage
@yim-lee
Bump swift-crypto to 2.5.0; address review feedback
f17a122
@yim-lee yim-lee force-pushed the swift-certificates-next branch from 4d9e8ab to f17a122 Compare April 19, 2023 15:58
@yim-lee yim-lee changed the title Update to swift-certificates 0.3.0 Update to swift-certificates 0.4.0 Apr 19, 2023
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 19, 2023

swiftlang/swift#64662

@swift-ci please smoke test

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 19, 2023

swiftlang/swift#64662

@swift-ci please test Windows platform

@shahmishal shahmishal merged commit c49480c into swiftlang:main Apr 20, 2023
@yim-lee yim-lee deleted the swift-certificates-next branch April 20, 2023 22:19
@compnerd
Copy link
Member

This breaks the Windows build as the new release of swift-certificates is not portable to non-Darwin platforms.

compnerd added a commit that referenced this pull request Apr 21, 2023
@compnerd
Revert "Update to swift-certificates 0.4.0 (#6316)"
f075048 
This reverts commit c49480c.
@compnerd compnerd mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yim-lee @compnerd @MaxDesiatov @neonichu @shahmishal