Skip to content

[Xcodeproj] conditionally add default linker path #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2016
Merged

[Xcodeproj] conditionally add default linker path #645

merged 1 commit into from
Sep 12, 2016

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Sep 12, 2016

rdar://problem/28253740 Don't add add the default linker search path
in Xcode generation if there are no C Targets dependees on Swift target

@aciidgh
[Xcodeproj] conditionally add default linker path
d0d0a57 
<rdar://problem/28253740> Don't add add the default linker search path
in Xcode generation if there are no C Targets dependees on Swift target
@aciidgh
Copy link
Contributor Author

aciidgh commented Sep 12, 2016

Ran tests locally.
It might get a bit slow but recursiveDependencies is supposed to be cached in future, Also will add tests for this after project model comes in. This should fix the recent warnings in generated Xcode projects

@aciidgh aciidgh merged commit a0829b3 into swiftlang:master Sep 12, 2016
@aciidgh aciidgh deleted the fix-default-linker-path branch September 12, 2016 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aciidgh