Skip to content

[5.9] Disable testImportOfMissedDepWarning #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

neonichu
Copy link
Contributor

The underlying functionality this tests appears to be broken when using certain versions of swift-driver, so we have to disable it for now.

(cherry picked from commit fc17625)

The underlying functionality this tests appears to be broken when using certain versions of swift-driver, so we have to disable it for now.

(cherry picked from commit fc17625)
@neonichu neonichu added the swift 5.9 This PR targets the 5.9 branch label Apr 25, 2023
@neonichu neonichu self-assigned this Apr 25, 2023
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

Seeing this is in the Windows build:

Assertion failed: RecordKind == SIL_ONE_TYPE_ONE_OPERAND && "Layout should be OneTypeOneOperand.", file C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift\lib\Serialization\DeserializeSIL.cpp, line 1381

cc @compnerd

@compnerd
Copy link
Member

@neonichu hmm, that seems like a general deserialisation issue? CC: @xymus

@neonichu
Copy link
Contributor Author

Wondering if it is just flakiness, since I landed a few 5.9 changes earlier.

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test windows

@neonichu neonichu merged commit 7a539cc into release/5.9 Apr 26, 2023
@neonichu neonichu deleted the disable-testImportOfMissedDepWarning-59 branch April 26, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift 5.9 This PR targets the 5.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants