Support macro targets in plugin context #6483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently prevents the use of plugins in any package graph that happens to include one or more macro targets which seems extremely unfortunate. This fix is slightly ugly because `PackagePlugin` should not concretely know about macros. An alternative could be excluding macros from the project model that plugins see. rdar://108531004
neonichu
requested review from
abertelrud,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 26, 2023
MaxDesiatov
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently prevents the use of plugins in any package graph that happens to include one or more macro targets which seems extremely unfortunate.
This fix is slightly ugly because
PackagePluginshould not concretely know about macros. An alternative could be excluding macros from the project model that plugins see.rdar://108531004