[5.9] improve string interpolation of errors #6488
Merged
+391
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: better error messages changes: * audit usage of "\(error)" and replace them with "\(error.interpolationDescription)" * add ADPI to pass an optional underlying error to observability's debug, info and warn calls such that it automatically interpolates the error correctly * update call sites rdar://108418554
|
@swift-ci smoke test |
neonichu
approved these changes
Apr 26, 2023
|
@swift-ci smoke test macOS |
MaxDesiatov
approved these changes
Apr 27, 2023
abertelrud
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9 cherry pick of #6482