Make observabilityScope and callbackQueue API args instead of instance members #6601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e members Motivation: SSWG package collection (https://github.com/swift-server/sswg-collection) is failing to sign. The code crashes with code 139. To reproduce: 1. Clone https://github.com/swift-server/sswg-collection 2. Run `docker-compose -f docker/docker-compose.yaml run generate` to generate `.output/collection.json` or place a valid collection file in `.output`. 3. Place signing key and cert under `certs`. 4. Run `docker-compose -f docker/docker-compose.yaml run sign` Expected: A signed collection file gets created `.output/collection-signed.json` Actual: `Error: 139` Modifications: After debugging it seems like referencing `self.observabilityScope`, etc. causes the crash, thus changing `observabilityScope`, `callbackQueue`, `encoder`, `decoder` from instance members to API args or local value.
yim-lee
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
tomerd
approved these changes
May 23, 2023
|
Closing this in favor of #6609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SSWG package collection (https://github.com/swift-server/sswg-collection) is failing to sign. The code crashes with code 139.
To reproduce:
docker-compose -f docker/docker-compose.yaml run generateto generate.output/collection.jsonor place a valid collection file in.output.certs.docker-compose -f docker/docker-compose.yaml run signExpected: A signed collection file gets created
.output/collection-signed.jsonActual:
Error: 139Modifications:
After debugging it seems like referencing
self.observabilityScope, etc. causes the crash, thus changingobservabilityScope,callbackQueue,encoder,decoderfrom instance members to API args or local value.Need swiftlang/swift-package-collection-generator#62 for signer to work