BuildDescription: Set output path for bc files #6611
Conversation
rauhul
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
|
So I'm assuming this is always a strict either/or? Or is there a situation where the compiler would try to emit both and fail because we're using the same path? |
MaxDesiatov
changed the title
|
+1 to that question, it's unclear what happens when both of these paths are used at once by different tools. |
|
You both are right, I'm talking to artem about this now and will hopefully find a better solution... |
|
The only time an issue can arise is if you pass |
I'm not sure if the assertion error message is helpful enough. In what cases can that happen? Would it make sense to just write to a file with a different extension? |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
- Updates spm to pass the object file path as the output path for bitcode files for use when building with lto. A more ideal solution may be to use a different path for bitcode files, however using the `.o` extension is also a common pattern and requires a significantly less invasive diff.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
1 similar comment
|
@swift-ci please smoke test windows |
| name: .customLong("experimental-lto-mode"), | ||
| help: .hidden | ||
| ) | ||
| public var linkTimeOptimizationMode: LinkTimeOptimizationMode? |
There was a problem hiding this comment.
Could this use that enum directly instead of creating a proxy enum, as they seem identical to each other?
| public var linkTimeOptimizationMode: LinkTimeOptimizationMode? | |
| public var linkTimeOptimizationMode: BuildParameters.LinkTimeOptimizationMode? |
There was a problem hiding this comment.
@neonichu suggested discrete enums, I'm happy to go either way.
There was a problem hiding this comment.
I think they should be separate because one is for argument parsing and one is for the build. They just happen to be the same right now, but that's coincidental not inherent.
|
@swift-ci please smoke test windows |
|
@swift-ci please smoke test windows |
|
@tomerd I wonder if we need to mention this in |
|
good point, we can add and make sure its mentioned as experimental |
-experimental-lto-modeoption which canbe set to either "full" or "thin" enabling the use of llvm LTO for
both swift and c targets. Updates BuildParameters with a matching
linkTimeOptimizationMode and updates SwiftTargetBuildDescription to
use the proper file extension for bitcode objects as well as place
them in the proper output location.