[5.9] Preserve port when computing the login URL #6715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Same as #6711 but for 5.9.)
When using a registry URL that contains a port, ensure the port is preserved when computing the login URL.
Motivation:
Currently if you run the following
You might get something like
That's because the login url is built like this and ignores the port:
URL(string: "https://\(host)\(loginAPIPath ?? "/login")")
Modifications:
URLComponents
to build the login URL (which maintains the port)Result:
SPM can use registry URLs with ports.