Skip to content

Fix another XCBuild compatibility issue #6762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

neonichu
Copy link
Contributor

Similar to #6752, there was another case where we needed the new setting.

rdar://113157040

Similar to #6752, there was another case where we needed the new setting.

rdar://113157040
@neonichu neonichu self-assigned this Jul 31, 2023
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

Windows CI is failing with

$ "not" "t:\\1\\bin\\swift.exe" "-module-cache-path" "T:\1\swift-test-results\x86_64-unknown-windows-msvc\clang-module-cache" "-swift-version" "4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.10:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999" "-libc" "MD" "-sdk" "" "-deprecated-integrated-repl" "C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift\test\Driver\options-repl.swift"
$ "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe" "C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift\utils\PathSanitizingFileCheck" "--allow-unused-prefixes" "--sanitize" "BUILD_DIR=T:/1/tools/swift" "--sanitize" "SOURCE_DIR=C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/swift" "--use-filecheck" "t:\1\bin\filecheck.exe" "--enable-windows-compatibility" "-check-prefix=REPL_NO_FILES" "C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift\test\Driver\options-repl.swift"
$ ":" "RUN: at line 8"
$ "rm" "-rf" "T:\1\tools\swift\test-windows-x86_64\Driver\Output\options-repl.swift.tmp"
# command stderr:
Error: 'rm' command failed, [WinError 32] The process cannot access the file because it is being used by another process.
error: command failed with exit status: 1

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.
FAIL: Swift(windows-x86_64) :: Driver/windows-link-job.swift (4601 of 9636)

@MaxDesiatov
Copy link
Contributor

that Windows failure seems sporadic, I saw it previously, but repeated Windows CI runs on other PRs made it go away sometimes. cc @compnerd

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test linux

@neonichu neonichu force-pushed the fix-xcbuild-compatibility-issue-take-2 branch from e6739d3 to 63e7362 Compare July 31, 2023 23:26
@compnerd
Copy link
Member

@MaxDesiatov yes - that would be sporadic - it is a file in use issue.

@neonichu neonichu merged commit 2dceb21 into main Aug 1, 2023
@neonichu neonichu deleted the fix-xcbuild-compatibility-issue-take-2 branch August 1, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants