Invoke build tool plugins based on allTargets
#6776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
abertelrud,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
@swift-ci smoke test linux |
MaxDesiatov
reviewed
Aug 4, 2023
Currently, we're only invoking build tool plugins for reachable targets which does not seem correct based on the fact that we're willing to build targets out of reachable, e.g. when executing a command plugin. rdar://113264168
neonichu
force-pushed
the
invoke-plugins-for-all-targets
branch
from
695fd11 to
3a8dbfa
Compare
|
@swift-ci please test |
Not really sure how to add a test case for this since it requires a quite elaborate setup to demonstrate the original issue. I think that's ok though since using |
|
would be possible to add a test? |
tomerd
approved these changes
Sep 14, 2023
See comment above. In principle yes, but the cost seems high for something that's obviously just wrong. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, we're only invoking build tool plugins for reachable targets which does not seem correct based on the fact that we're willing to build targets out of reachable, e.g. when executing a command plugin. rdar://113264168
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, we're only invoking build tool plugins for reachable targets which does not seem correct based on the fact that we're willing to build targets out of reachable, e.g. when executing a command plugin. rdar://113264168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're only invoking build tool plugins for reachable targets which does not seem correct based on the fact that we're willing to build targets out of reachable, e.g. when executing a command plugin.
rdar://113264168