Skip to content

Fix platforms declaration in IntegrationTests package #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix platforms declaration in IntegrationTests package #6873

merged 1 commit into from
Sep 6, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Sep 6, 2023

Not sure why this is only becoming visible now, it seems like this should have been needed since swiftlang/swift-tools-support-core@be6f396

@neonichu
Fix platforms declaration in IntegrationTests package
8cc4d6b 
Not sure why this is only becoming visible now, it seems like this should have been needed since swiftlang/swift-tools-support-core@be6f396
@neonichu neonichu requested a review from abertelrud as a code owner September 6, 2023 18:43
@neonichu neonichu self-assigned this Sep 6, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Sep 6, 2023

@swift-ci please test

@neonichu neonichu mentioned this pull request Sep 6, 2023
Merged
@neonichu
Copy link
Contributor Author

neonichu commented Sep 6, 2023 

stderr: error: 'validlayouts_singlemodule_library': Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsoverlay", "/var/folders/7n/r31lzfjx6556jgc6vg55_cg80000gn/T/TemporaryDirectory.HnePB4/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx12.0", "-sdk", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk", "-F", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks", "-I", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "4.2", "-I", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk", "-package-description-version", "4.2.0", "-module-cache-path", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release", "/private/var/folders/7n/r31lzfjx6556jgc6vg55_cg80000gn/T/ValidLayouts_SingleModule_Library.p5o8wV/ValidLayouts_SingleModule_Library/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/7n/r31lzfjx6556jgc6vg55_cg80000gn/T/TemporaryDirectory.KmMfzi/validlayouts_singlemodule_library-manifest"])
<unknown>:0: error: cannot open file '/private/var/folders/7n/r31lzfjx6556jgc6vg55_cg80000gn/T/Miscellaneous_TargetPackageAccess.JJIrVX/libPkg/.build/x86_64-apple-macosx/debug/MainLib.build/module.modulemap' (No such file or directory)
/private/var/folders/7n/r31lzfjx6556jgc6vg55_cg80000gn/T/ValidLayouts_SingleModule_Library.p5o8wV/ValidLayouts_SingleModule_Library/Package.swift:1:8: error: failed to build module 'Foundation'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.7.1 (swiftlang-5.7.1.134.4 clang-1400.0.29.51)', while this compiler is 'Apple Swift version 5.9-dev (LLVM 104f7296fe3d75d, Swift 2c3c3c1933f3556)'). Please select a toolchain which matches the SDK.
import Foundation
       ^

Is it time yet to disable the macOS smoke tests?

@neonichu
Copy link
Contributor Author

neonichu commented Sep 6, 2023

@swift-ci please test macOS

@neonichu neonichu merged commit ab95810 into main Sep 6, 2023
@neonichu neonichu deleted the fix-IntegrationTests-platforms branch September 6, 2023 23:10
neonichu added a commit that referenced this pull request Sep 20, 2023
@neonichu
Revert "Fix platforms declaration in IntegrationTests package (#6873
1e5c442 
)"

This reverts commit ab95810.

This shouldn't have been necessary since the automatic raise of test deployment targets should be sufficient here.
neonichu added a commit that referenced this pull request Sep 21, 2023
@neonichu
Revert "Fix platforms declaration in IntegrationTests package (#6873
d0ae2c5 
)" (#6934)

This reverts commit ab95810.

This shouldn't have been necessary since the automatic raise of test deployment targets should be sufficient here.
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
@neonichu @MaxDesiatov
Revert "Fix platforms declaration in IntegrationTests package (#6873
5d31fac 
)" (#6934)

This reverts commit ab95810.

This shouldn't have been necessary since the automatic raise of test deployment targets should be sufficient here.
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
@neonichu @MaxDesiatov
Revert "Fix platforms declaration in IntegrationTests package (#6873
2eb2ddd 
)" (#6934)

This reverts commit ab95810.

This shouldn't have been necessary since the automatic raise of test deployment targets should be sufficient here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@tomerd tomerd tomerd approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @MaxDesiatov @tomerd