Fix missing from arguments in PackageDependency's comments
#6876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.upToNextMajor` and `.upToNextMinor` need a `from` argument, but it was missing in the comments.
bc-lee
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
approved these changes
Sep 7, 2023
|
@swift-ci test |
neonichu
approved these changes
Sep 8, 2023
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
`.upToNextMajor` and `.upToNextMinor` need a `from` argument, but it was missing in the comments.
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
`.upToNextMajor` and `.upToNextMinor` need a `from` argument, but it was missing in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.upToNextMajorand.upToNextMinorneed afromargument, but it was missing in the comments.Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
While I was modifying a
Package.swiftfile, I noticed that the comments for.upToNextMajorand.upToNextMinorwere missing thefromargument. So, I'd like to fix that.Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]