Skip to content

Support experimental test summary on non-Darwin #6878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Sep 8, 2023

In this case we inject the code directly into the entry point executable. We also need to significantly change the observation code because of the vast API differences between XCTest and swift-corelibs-xctest. Notably, we cannot support features like expected failures, attachments etc since they are not available on non-Darwin platforms.

rdar://115067756

@neonichu neonichu requested a review from tomerd as a code owner September 8, 2023 23:09
@neonichu neonichu self-assigned this Sep 8, 2023
In this case we inject the code directly into the entry point executable. We also need to significantly change the observation code because of the vast API differences between XCTest and swift-corelibs-xctest. Notably, we cannot support features like expected failures, attachments etc since they are not available on non-Darwin platforms.

rdar://115067756
@neonichu neonichu force-pushed the experimental-test-output-on-linux branch from b0f8411 to 37f9585 Compare September 8, 2023 23:10
@neonichu
Copy link
Contributor Author

neonichu commented Sep 8, 2023

@swift-ci please test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@neonichu neonichu merged commit ca45050 into main Sep 11, 2023
@neonichu neonichu deleted the experimental-test-output-on-linux branch September 11, 2023 17:25
compnerd added a commit that referenced this pull request Sep 12, 2023
compnerd added a commit that referenced this pull request Sep 13, 2023
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
In this case we inject the code directly into the entry point executable. We also need to significantly change the observation code because of the vast API differences between XCTest and swift-corelibs-xctest. Notably, we cannot support features like expected failures, attachments etc since they are not available on non-Darwin platforms.

rdar://115067756
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
In this case we inject the code directly into the entry point executable. We also need to significantly change the observation code because of the vast API differences between XCTest and swift-corelibs-xctest. Notably, we cannot support features like expected failures, attachments etc since they are not available on non-Darwin platforms.

rdar://115067756
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants