Skip to content

Rename "destination" to "Swift SDK" in comments and code #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

MaxDesiatov
Copy link
Contributor

While user-visible strings were cleaned up separately in #6918, there are still uses of "destinations" left in variable/function naming and comments. Let's clean those up too.

While user-visible strings were cleaned up separately in #6918, there are still uses of "destinations" left in variable/function naming and comments. Let's clean those up too.
@rauhul
Copy link
Member

rauhul commented Sep 19, 2023

thank you for this, the mix of names made the code much more confusing to try to understand

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) September 19, 2023 17:53
MaxDesiatov added a commit that referenced this pull request Sep 19, 2023
Cherry-pick of #6927.

While user-visible strings were cleaned up separately in #6918, there are still uses of "destinations" left in variable/function naming and comments. Let's clean those up too.
@MaxDesiatov MaxDesiatov self-assigned this Sep 19, 2023
@MaxDesiatov MaxDesiatov merged commit 76504fd into main Sep 19, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/swift-sdk-bis branch September 19, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants