[NFC] Move manifests-related code to Workspace+Manifests.swift
#7000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Workspace.swift` is currently at ~4600 LoC and has a risk of growing larger. It has become an assorted collection of stateful code, and splitting it into separate components should make it more manageable. I started with manifests-related code, moving it `Workspace+Manifests.swift`.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
neonichu
approved these changes
Oct 13, 2023
MaxDesiatov
added a commit
that referenced
this pull request
Oct 23, 2023
### Motivation: `Workspace.swift` has grown to an unmanageable size: ~4k lines, close to 4200 before #7000 was merged. The `Workspace` type is the main API for SourceKit-LSP interactions with SwiftPM. As we'd like to add more cross-compilation functionality here (e.g. allowing SourceKit-LSP to select a different Swift SDK), this API should be more navigable and easier to work with. Since the amount of `public` functions on `Workspace` is limited, we should keep them grouped in the main `Workspace.swift` file, but the actual implementations can be moved to separate files for easier subsequent refactoring and further changes. ### Modifications: Split `Workspace.swift` into more files, with each file corresponding to an implementation aspect of the `Workspace` API. Also applied our formatting rules to the new files. ### Result: `Workspace.swift` is now only 1384 lines long. When looking for a specific `Workspace` functionality implementation, you can look it up in separate files that correspond to a larger area grouping that functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace.swiftis currently at ~4600 LoC and has a risk of growing larger. It has become an assorted collection of stateful code, and splitting it into separate components should make it more manageable.I started with manifests-related code, moving it to
Workspace+Manifests.swift.