SwiftSyntax version in new macro template has trailing period in dependency version, causing error reading manifest #7018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency version, causing error reading manifest This fixes a regression I believe was introduced in swiftlang#6774 where the new macro package template has its dependency on swift-syntax expressed as `from: "509.0.0."`, including an unncessary trailing period character. This causes an error reading the manifest. I have not tested this, but I experienced the bug and from source inspection believe this is likely the issue. Resolves rdar://117132800
stmontgomery
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
requested changes
Oct 18, 2023
It's not precisely what you asked for, but I just added a few very targeted unit tests as a start. |
|
@swift-ci test |
neonichu
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression I believe was introduced in #6774 where the new macro package template has its dependency on swift-syntax expressed as
from: "509.0.0.", including an unncessary trailing period character. This causes an error reading the manifest.I have not tested this, but I experienced the bug and from source inspection believe this is likely the issue.
Resolves rdar://117132800