Skip to content

Support additional dependencies in forced resolution mode #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Support additional dependencies in forced resolution mode #7023

merged 1 commit into from
Nov 6, 2023

Conversation

neonichu
Copy link
Contributor

rdar://115630439

@neonichu neonichu self-assigned this Oct 20, 2023
@neonichu
Copy link
Contributor Author

Seems like adding to managed dependencies isn't the only missing piece here, so more work is required for this.

@neonichu
Copy link
Contributor Author

neonichu commented Nov 3, 2023

Ah the issue with this PR is actually pretty simple: we need to prepopulate managed dependencies a bit earlier, at the point where I am doing it, they have already been dropped from the equation.

@neonichu neonichu force-pushed the support-additional-dependencies-in-forced-resolution-mode branch from d22436c to b7cd543 Compare November 3, 2023 18:17
@neonichu neonichu changed the title WIP: Support additional dependencies in forced resolution mode Support additional dependencies in forced resolution mode Nov 3, 2023
@neonichu neonichu marked this pull request as ready for review November 3, 2023 18:17
@neonichu neonichu force-pushed the support-additional-dependencies-in-forced-resolution-mode branch from b7cd543 to 67ebd97 Compare November 3, 2023 18:20
@neonichu
Copy link
Contributor Author

neonichu commented Nov 3, 2023

@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Nov 3, 2023

@swift-ci please test windows

@neonichu neonichu mentioned this pull request Nov 3, 2023
Closed
@neonichu
Copy link
Contributor Author

neonichu commented Nov 3, 2023

@swift-ci please test windows

1 similar comment
@shahmishal
Copy link
Member

@swift-ci please test windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

MaxDesiatov
MaxDesiatov approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the terminology documented anywhere in the codebase? What's the best place to check what a managed dependency or a root is?

@neonichu
Copy link
Contributor Author

neonichu commented Nov 6, 2023

Do we have the terminology documented anywhere in the codebase? What's the best place to check what a managed dependency or a root is?

Don't think we have any meaningful docs for this.

@neonichu neonichu merged commit a9cbf5c into main Nov 6, 2023
@neonichu neonichu deleted the support-additional-dependencies-in-forced-resolution-mode branch November 6, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@tomerd tomerd Awaiting requested review from tomerd

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @shahmishal @MaxDesiatov