Ensure Xcode SDK paths are set when running test targets. #7040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, some of our code paths that run test targets don't correctly set the `DYLD_FRAMEWORK_PATH` and `DYLD_LIBRARY_PATH` arguments on macOS. This hasn't been a problem in practice because the XCTest helper tool is able to sort it out for us, but my plan with swift-testing is to run an executable directly (like we do for corelibs-xctest.) That means we'll have a code path that could potentially rely on XCTest or other Apple SDK bits, but which is not calling through the XCTest helper tool. This change hoists our setting of those arguments to a position where they are always set (on macOS only!) before we run a test target, regardless of build style.
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
|
seems fine to me, but @neonichu to review |
briancroom
approved these changes
Oct 26, 2023
stmontgomery
approved these changes
Oct 27, 2023
MaxDesiatov
reviewed
Oct 27, 2023
neonichu
approved these changes
Oct 30, 2023
|
@MaxDesiatov We can write a test that does that, but it would be a bit tautological. I was planning to write some tests of broader test target behaviour in subsequent PRs that would cover these variables. |
neonichu
added a commit
that referenced
this pull request
Nov 6, 2023
)" This reverts commit bcad083.
grynspan
added a commit
that referenced
this pull request
Nov 14, 2023
Currently, some of our code paths that run test targets don't correctly set the `DYLD_FRAMEWORK_PATH` and `DYLD_LIBRARY_PATH` arguments on macOS. This hasn't been a problem in practice because the XCTest helper tool is able to sort it out for us, but my plan with swift-testing is to run an executable directly (like we do for corelibs-xctest.) That means we'll have a code path that could potentially rely on XCTest or other Apple SDK bits, but which is not calling through the XCTest helper tool. This change hoists our setting of those arguments to a position where they are always set (on macOS only!) before we run a test target, regardless of build style. This change was previously landed as #7040 but was reverted while we investigated a toolchain regression. We do not believe #7040 is the root cause of that issue, so this PR reapplies it.
grynspan
added a commit
that referenced
this pull request
Nov 14, 2023
Currently, some of our code paths that run test targets don't correctly set the `DYLD_FRAMEWORK_PATH` and `DYLD_LIBRARY_PATH` arguments on macOS. This hasn't been a problem in practice because the XCTest helper tool is able to sort it out for us, but my plan with swift-testing is to run an executable directly (like we do for corelibs-xctest.) That means we'll have a code path that could potentially rely on XCTest or other Apple SDK bits, but which is not calling through the XCTest helper tool. This change hoists our setting of those arguments to a position where they are always set (on macOS only!) before we run a test target, regardless of build style. This change was previously landed as #7040 but was reverted (#7054) while we investigated a toolchain regression. We do not believe #7040 is the root cause of that issue, so this PR reapplies it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of our code paths that run test targets don't correctly set the
DYLD_FRAMEWORK_PATHandDYLD_LIBRARY_PATHarguments on macOS. This hasn't been a problem in practice because the XCTest helper tool is able to sort it out for us, but my plan with swift-testing is to run an executable directly (like we do for corelibs-xctest.) That means we'll have a code path that could potentially rely on XCTest or other Apple SDK bits, but which is not calling through the XCTest helper tool.This change hoists our setting of those arguments to a position where they are always set (on macOS only!) before we run a test target, regardless of build style.