Infer properties of derived test target. #7041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
briancroom
reviewed
Oct 26, 2023
briancroom
approved these changes
Oct 26, 2023
|
@swift-ci please test |
|
Ah, self-hosted compiler is too old for Fancy If™. Will fix when I am back at a desk next week. |
neonichu
reviewed
Oct 30, 2023
Right now, when we construct the derived test target used on Linux/Windows with corelibs-xctest, we don't preserve the `platforms` property. The toolchain then infers a value for it based on the current OS. Since Swift doesn't currently support versioning on those platforms, the end result is the same. However, if we want to start using a derived test target with swift-testing on Apple platforms, we need to propagate this information correctly. This PR does that.
…t.init(product:targets:)
grynspan
force-pushed
the
jgrynspan/derived-test-target-platforms
branch
from
5077844 to
dfb9785
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
neonichu
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when we construct the derived test target used on Linux/Windows with corelibs-xctest, we don't preserve the
platformsproperty. The toolchain then infers a value for it based on the current OS. Since Swift doesn't currently support versioning on those platforms, the end result is the same.However, if we want to start using a derived test target with swift-testing on Apple platforms, we need to propagate this information correctly. This PR does that.