track SDK dependencies (rdar://115777026) #7172
Conversation
pusukuri
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci test |
pusukuri
changed the title
|
@swift-ci test macos |
|
@swift-ci test |
|
@swift-ci test |
|
@pusukuri would mind resolving conflicts? No need to rebase and force push, merge commits in the PR branch are fine too, as long as you squash and merge in the end. |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
| @@ -29,6 +29,9 @@ public struct BuildParameters: Encodable { | |||
| /// The path to the data directory. | |||
| public var dataPath: AbsolutePath | |||
|
|
|||
| /// The path to the SDKROOT directory. | |||
| public var sdkPath: AbsolutePath? | |||
There was a problem hiding this comment.
There's already sdkRootPath available on the var toolchain: Toolchain property below. Is this any different from that?
There was a problem hiding this comment.
Thank you @MaxDesiatov I addressed your comment.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
|
@swift-ci test windows |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
Windows failures seem unrelated |
|
@swift-ci test windows |
|
Thank you @MaxDesiatov |
Compiler commands need to track SDK dependencies to trigger rebuilds when the SDK changes rdar://115777026
Motivation:
track SDK dependencies to avoid triggering rebuilds when the SDK changes rdar://115777026