-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Start using package
for some APIs
#7240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As our CI was updated to 5.9, and the currently developed version is 5.11, it makes sense to bump the minimum supported version to be able to new use new language features. Use of `package` in our APIs has a particular interest for us.
@swift-ci test |
1 similar comment
@swift-ci test |
@swift-ci test windows |
swift-tools-version
to 5.9 in Package.swift
swift-tools-version
to 5.9, start using package
for some APIs
@swift-ci test |
@swift-ci test windows |
@swift-ci test |
@swift-ci test windows |
compnerd
reviewed
Jan 11, 2024
a11fe0e
to
17ad662
Compare
17ad662
to
0848f7a
Compare
@swift-ci test |
@swift-ci test windows |
1 similar comment
@swift-ci test windows |
@swift-ci test |
@swift-ci test windows |
@swift-ci test |
@swift-ci test windows |
1 similar comment
@swift-ci test windows |
neonichu
approved these changes
Jan 12, 2024
swift-tools-version
to 5.9, start using package
for some APIspackage
for some APIs
MaxDesiatov
pushed a commit
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmake
Changes related to CMake configuration
dependencies
Changes to dependencies and relevant checks
enhancement
test suite
improvements to SwiftPM test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
package
in our APIs has a particular interest for us, as it allows us to make sure we don't expose certain types and functions in out public API.Here we're making changes to some declarations in
SPMTestSupport
andBasics
frompublic
topackage
.