Skip to content

Start using package for some APIs #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 10, 2024

Use of package in our APIs has a particular interest for us, as it allows us to make sure we don't expose certain types and functions in out public API.

Here we're making changes to some declarations in SPMTestSupport and Basics from public to package.

As our CI was updated to 5.9, and the currently developed version is 5.11, it makes sense to bump the minimum supported version to be able to new use new language features. Use of `package` in our APIs has a particular interest for us.
@MaxDesiatov MaxDesiatov added the dependencies Changes to dependencies and relevant checks label Jan 10, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov changed the title Bump swift-tools-version to 5.9 in Package.swift Bump swift-tools-version to 5.9, start using package for some APIs Jan 10, 2024
@MaxDesiatov MaxDesiatov enabled auto-merge (squash) January 10, 2024 16:30
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov force-pushed the maxd/bump-tools-version-5.9 branch from a11fe0e to 17ad662 Compare January 11, 2024 09:43
@MaxDesiatov MaxDesiatov force-pushed the maxd/bump-tools-version-5.9 branch from 17ad662 to 0848f7a Compare January 11, 2024 09:46
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov self-assigned this Jan 11, 2024
@MaxDesiatov MaxDesiatov requested a review from compnerd January 11, 2024 11:36
@MaxDesiatov MaxDesiatov disabled auto-merge January 11, 2024 11:36
@MaxDesiatov MaxDesiatov added enhancement test suite improvements to SwiftPM test suite labels Jan 11, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov requested a review from etcwilde January 11, 2024 21:27
@MaxDesiatov MaxDesiatov added the cmake Changes related to CMake configuration label Jan 11, 2024
@MaxDesiatov MaxDesiatov changed the title Bump swift-tools-version to 5.9, start using package for some APIs Start using package for some APIs Jan 12, 2024
@MaxDesiatov MaxDesiatov merged commit d14ff89 into main Jan 12, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/bump-tools-version-5.9 branch January 12, 2024 19:15
MaxDesiatov pushed a commit that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Changes related to CMake configuration dependencies Changes to dependencies and relevant checks enhancement test suite improvements to SwiftPM test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants