Skip to content

Revert "Start using package for some APIs" #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,5 @@ find_package(dispatch QUIET)
find_package(Foundation QUIET)
find_package(SQLite3 REQUIRED)

# Enable `package` modifier for the whole package.
add_compile_options("$<$<COMPILE_LANGUAGE:Swift>:-package-name;SwiftPM>")

add_subdirectory(Sources)
add_subdirectory(cmake/modules)
1 change: 0 additions & 1 deletion Sources/Basics/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ target_link_libraries(Basics PUBLIC
target_link_libraries(Basics PRIVATE
SPMSQLite3
TSCclibc)

# NOTE(compnerd) workaround for CMake not setting up include flags yet
set_target_properties(Basics PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY})
Expand Down
11 changes: 5 additions & 6 deletions Sources/Basics/OSSignpost.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extension os.OSLog {
#endif

/// Emits a signpost.
@inlinable package func os_signpost(
@inlinable public func os_signpost(
_ type: SignpostType,
name: StaticString,
signpostID: SignpostID = .exclusive
Expand All @@ -39,8 +39,8 @@ extension os.OSLog {
#endif
}

@usableFromInline
package enum SignpostType {

public enum SignpostType {
case begin
case end
case event
Expand All @@ -61,8 +61,7 @@ package enum SignpostType {
#endif
}

@usableFromInline
package enum SignpostID {
public enum SignpostID {
case exclusive

#if canImport(os)
Expand All @@ -78,7 +77,7 @@ package enum SignpostID {
}


package enum SignpostName {
public enum SignpostName {
public static let updatingDependencies: StaticString = "updating"
public static let resolvingDependencies: StaticString = "resolving"
public static let pubgrub: StaticString = "pubgrub"
Expand Down
2 changes: 1 addition & 1 deletion Sources/SPMTestSupport/GitRepositoryExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import enum TSCUtility.Git

/// Extensions useful for unit testing purposes.
/// Note: These are not thread safe.
package extension GitRepository {
public extension GitRepository {
/// Create the repository using git init.
func create() throws {
try systemQuietly([Git.tool, "-C", self.path.pathString, "init"])
Expand Down
34 changes: 17 additions & 17 deletions Sources/SPMTestSupport/MockArchiver.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,22 @@

import Basics

package class MockArchiver: Archiver {
package typealias ExtractionHandler = (
public class MockArchiver: Archiver {
public typealias ExtractionHandler = (
MockArchiver,
AbsolutePath,
AbsolutePath,
(Result<Void, Error>) -> Void
) throws -> Void
package typealias CompressionHandler = (
public typealias CompressionHandler = (
MockArchiver,
AbsolutePath,
AbsolutePath,
(Result<Void, Error>) -> Void
) throws -> Void
package typealias ValidationHandler = (MockArchiver, AbsolutePath, (Result<Bool, Error>) -> Void) throws -> Void
public typealias ValidationHandler = (MockArchiver, AbsolutePath, (Result<Bool, Error>) -> Void) throws -> Void

package struct Extraction: Equatable {
public struct Extraction: Equatable {
public let archivePath: AbsolutePath
public let destinationPath: AbsolutePath

Expand All @@ -37,7 +37,7 @@ package class MockArchiver: Archiver {
}
}

package struct Compression: Equatable {
public struct Compression: Equatable {
public let directory: AbsolutePath
public let destinationPath: AbsolutePath

Expand All @@ -47,18 +47,18 @@ package class MockArchiver: Archiver {
}
}

package let supportedExtensions: Set<String> = ["zip"]
package let extractions = ThreadSafeArrayStore<Extraction>()
package let compressions = ThreadSafeArrayStore<Compression>()
package let extractionHandler: ExtractionHandler?
package let compressionHandler: CompressionHandler?
package let validationHandler: ValidationHandler?
public let supportedExtensions: Set<String> = ["zip"]
public let extractions = ThreadSafeArrayStore<Extraction>()
public let compressions = ThreadSafeArrayStore<Compression>()
public let extractionHandler: ExtractionHandler?
public let compressionHandler: CompressionHandler?
public let validationHandler: ValidationHandler?

package convenience init(handler: ExtractionHandler? = .none) {
public convenience init(handler: ExtractionHandler? = .none) {
self.init(extractionHandler: handler, compressionHandler: .none, validationHandler: .none)
}

package init(
public init(
extractionHandler: ExtractionHandler? = .none,
compressionHandler: CompressionHandler? = .none,
validationHandler: ValidationHandler? = .none
Expand All @@ -68,7 +68,7 @@ package class MockArchiver: Archiver {
self.validationHandler = validationHandler
}

package func extract(
public func extract(
from archivePath: AbsolutePath,
to destinationPath: AbsolutePath,
completion: @escaping (Result<Void, Error>) -> Void
Expand All @@ -85,7 +85,7 @@ package class MockArchiver: Archiver {
}
}

package func compress(
public func compress(
directory: AbsolutePath,
to destinationPath: AbsolutePath,
completion: @escaping (Result<Void, Error>) -> Void
Expand All @@ -102,7 +102,7 @@ package class MockArchiver: Archiver {
}
}

package func validate(path: AbsolutePath, completion: @escaping (Result<Bool, Error>) -> Void) {
public func validate(path: AbsolutePath, completion: @escaping (Result<Bool, Error>) -> Void) {
do {
if let handler = self.validationHandler {
try handler(self, path, completion)
Expand Down