Bump swift-argument-parser to 1.4.0
#7450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://118081439
This was referenced Apr 10, 2024
1 similar comment
MaxDesiatov
changed the title
swift-argument-parser to 1.3.1swift-argument-parser to 1.4.0
MaxDesiatov
requested review from
jakepetroules,
francescomikulis and
xedin
as code owners
…o maxd/bump-argument-parser # Conflicts: # Sources/PackageGraph/ModulesGraph+Loading.swift
rauhul
reviewed
Jul 4, 2024
| @@ -49,8 +49,9 @@ final class PackageCommandTests: CommandsTestCase { | |||
| } | |||
|
|
|||
| func testUsage() async throws { | |||
| throw XCTSkip("rdar://131126477") | |||
There was a problem hiding this comment.
Why? The reason for skipping is opaque to non apple contributors without a comment
There was a problem hiding this comment.
There is a regression in ArgumentParser 1.4.0 that won't allow this test to pass.
There was a problem hiding this comment.
Sure but what's the failure, because if it's noted in source and linked to a GitHub issue then others can contribute more easily.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://118081439