[6.0] Generated code for XCTest on non-Darwin needs to be actor-isolated. #7569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7566) On Linux, Windows, etc. (anywhere that uses swift-corelibs-xctest instead of XCTest.framework), SwiftPM is responsible for generating an entry point function that passes in all tests discovered at compile time. The compiler cannot tell whether the generated code is concurrency-safe. This PR modifies the generated code and makes it main-actor-isolated. Since it's only ever used in the program's main function, this is safe. Resolves #7556.
grynspan
added
bug
concurrency
swift test
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
stmontgomery
approved these changes
May 15, 2024
briancroom
approved these changes
May 15, 2024
bnbarham
approved these changes
May 15, 2024
|
When are we expecting this in a 6.0 release snapshot image? |
|
Whenever a nightly toolchain actually succeeds 😅 (https://ci.swift.org/view/Swift%206.0/job/oss-swift-6.0-package-trigger/) |
|
@Lukasa have you had a chance to check out |
|
Not yet, will aim to do so soon. |
|
Fantastic news, that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Ensure that the synthesized entry point for swift-corelibs-xctest is concurrency-safe by marking it
@MainActor.Scope: All XCTest-based tests built/run on non-Darwin platforms.
Original PR: #7566
Risk: Low. The change is necessary to suppress a concurrency diagnostic. The synthesized
main()function is implicitly main-actor-isolated.Testing: Added unit test to check for the diagnostic, verified it did not occur anymore with the change in place.
Reviewer: @bnbarham, @MaxDesiatov, @stmontgomery, @briancroom