[Build] NFC: A few minor refactorings to build operation state tracking #7660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
xedin
commented
Jun 13, 2024
MaxDesiatov
added
the
no functional change
MaxDesiatov
reviewed
Jun 13, 2024
MaxDesiatov
reviewed
Jun 13, 2024
MaxDesiatov
approved these changes
Jun 13, 2024
xedin
force-pushed
the
refactor-build-operation-progress-tracking
branch
from
67332d3 to
32e050f
Compare
|
@swift-ci please test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ng (#7660) ### Motivation: Trying to make it possible to share `createBuildOperation` between multiple implementations of `SPMCoreBuild.BuildSystem` in preparation to introduce an operation that would build plugin tools. ### Modifications: - Rename `BuildOperationBuildSystemDelegateHandler` into `LLBuildProgressTracker` which is a more neutral name that could be used by different llbuild operations if necessary. - Integrate `commandFailureHandler` into the progress tracker - Make `BuildOperation.createBuildSystem` stateless and use a single member to set both a new build system and its tracker. ### Result: The change it make it much easier to move `createBuildSystem` out of `BuildOperation` and into `SPMCoreBuild.BuildSystem` itself. (cherry picked from commit 9c0e48e)
MaxDesiatov
added a commit
that referenced
this pull request
Jun 27, 2024
Includes these PRs cherry-picked off `main` * #7605 * #7660 * #7667 * #7682 * #7687 * #7690 * #7684 * #7679 **Explanation**: Cherry-pick of recent NFC changes, which makes it easier to cherry-pick actual bug fixes onto 6.0 due to the reduced number of merge conflicts. **Scope**: broad, includes both modules graph and llbuild-related changes. **Risk**: low, the test suite is passing, no functional changes are included, and cherry-picked changes were incubated on `main` for some time. **Testing**: Existing automated test suite. **Issue**: N/A **Reviewers**: @xedin @MaxDesiatov @rauhul --------- Co-authored-by: Pavel Yaskevich <[email protected]> Co-authored-by: Danny Mösch <[email protected]> Co-authored-by: Rauhul Varma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Trying to make it possible to share
createBuildOperationbetween multiple implementations ofSPMCoreBuild.BuildSystemin preparation to introduce an operation that would build plugin tools.Modifications:
BuildOperationBuildSystemDelegateHandlerintoLLBuildProgressTrackerwhich is a more neutral name that could be used by different llbuild operations if necessary.commandFailureHandlerinto the progress trackerBuildOperation.createBuildSystemstateless and use a single member to set both a new build system and its tracker.Result:
The change it make it much easier to move
createBuildSystemout ofBuildOperationand intoSPMCoreBuild.BuildSystemitself.