Invalidate manifest cache when -Xbuild-tools-swiftc changes
#7760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test Linux |
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
I think we should cherry-pick this to 6.0, would you mind opening a PR against release/6.0 branch? |
|
Okay, opened it #7762 |
kateinoigakukun
deleted the
yt/invalidate-manifest-cache-on-build-tools-flags
branch
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest cache key should take into account flags passed to
-Xbuild-tools-swiftcMotivation:
SwiftPM did not re-evaluate manifests even after changing
-Xbuild-tools-swiftcModifications:
Hash those extra flags into manifest cache key
Result:
Manifest will be properly re-evaluated after changing
-Xbuild-tools-swiftc.