Add (partial) support for building on Windows using SwiftPM #7866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
bnbarham,
MaxDesiatov,
francescomikulis and
xedin
as code owners
MaxDesiatov
approved these changes
Aug 8, 2024
|
@swift-ci test |
owenv
approved these changes
Aug 8, 2024
The macOS CI is still using Swift 5.9. Is this expected or should I bump down the tools version in swift-toolchain-sqlite from 5.10 to 5.9? |
|
@swift-ci please test Windows |
|
@swift-ci please test macOS |
I'd prefer just bumping down for now. We should separately test bumping |
jakepetroules
commented
Aug 9, 2024
| @@ -854,7 +856,8 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil { | |||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", branch: relatedDependenciesBranch), | |||
| .package(url: "https://github.com/apple/swift-system.git", "1.1.1" ..< "1.4.0"), | |||
| .package(url: "https://github.com/apple/swift-collections.git", "1.0.1" ..< "1.2.0"), | |||
| .package(url: "https://github.com/apple/swift-certificates.git", "1.0.1" ..< "1.4.0"), | |||
| .package(url: "https://github.com/apple/swift-certificates.git", "1.0.1" ..< "1.6.0"), | |||
There was a problem hiding this comment.
Needed to pull in apple/swift-certificates#180 which fixes a Windows build break
This adds a dependency on the new swift-toolchain-sqlite package, which allows swift-package-manager to build using swift build on Windows (including tests) without any additional flags or preinstalled dependencies. It's "partial" because there is still one final blocker, which is that linking fails because we exceed the 65k exported symbol limit due to limitations in the build system, which can be addressed separately.
jakepetroules
force-pushed
the
windows-sqlite3
branch
from
ddb2fbb to
6af499a
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
jakepetroules
added a commit
that referenced
this pull request
Aug 12, 2024
This continues from the support added in #7866. While we can't build on Windows as-is due to exceeding the 65k exported symbol limit, in turn due to limitations in the build system, we can apply -static to all of the library targets which are known to be linked statically, in order to get that symbol count down. Note that this uses unsafeFlags, which is normally not recommended, however given that we are already using unsafeFlags elsewhere in the manifest, this seems reasonable enough for now until we can improve support for static linking on Windows. Building the test targets still exceeds the symbol count though.
jakepetroules
added a commit
that referenced
this pull request
Aug 13, 2024
This continues from the support added in #7866. While we can't build on Windows as-is due to exceeding the 65k exported symbol limit, in turn due to limitations in the build system, we can apply -static to all of the library targets which are known to be linked statically, in order to get that symbol count down. Note that this uses unsafeFlags, which is normally not recommended, however given that we are already using unsafeFlags elsewhere in the manifest, this seems reasonable enough for now until we can improve support for static linking on Windows. Building the test targets still exceeds the symbol count though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency on the new swift-toolchain-sqlite package, which allows swift-package-manager to build using swift build on Windows (including tests) without any additional flags or preinstalled dependencies.
It's "partial" because there is still one final blocker, which is that linking fails because we exceed the 65k exported symbol limit due to limitations in the build system, which can be addressed separately.