[Build] Free BuildPlan from BuildTriple
#7877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
owenv
as code owners
|
@swift-ci please test |
xedin
commented
Aug 13, 2024
rauhul
reviewed
Aug 13, 2024
MaxDesiatov
reviewed
Aug 13, 2024
MaxDesiatov
approved these changes
Aug 13, 2024
xedin
changed the title
BuildPlan from BuildTriple.BuildPlan from BuildTriple
|
These changes led me to discover #7879 |
xedin
force-pushed
the
no-more-buildTriple-use-in-build-plan
branch
from
2940bae to
41a559a
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
This method is going to be very useful for planning various build descriptions because they currently rely on a modules graph + description lookup into the build plan which is not great because it means that modules graph has to know about module destinations.
…odule build description BuildPlan adjacent things should use this instead of reaching for a module graph and lookup up descriptions.
…ons for build plan
Instead of using `Resolved{Product, Module}.ID` to storage module
and product collections in the build plan, switch to use newly added
`Identifiable` conformation on `{Product, Module}BuildDescription`.
This is yet another step (if not the last one) on the path to remove
`buildTriple` from `Resolved{Product, Module}` identifiers.
xedin
force-pushed
the
no-more-buildTriple-use-in-build-plan
branch
from
41a559a to
56f3c85
Compare
xedin
requested review from
dschaefer2,
shawnhyam,
bripeticca and
plemarquand
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is yet another step (if not the last one) on the path to remove
buildTriplefromResolved{Product, Module}identifiers and switcheverything that requires destination to use information from the build
plan.
Modifications:
Resolved{Product, Module}.IDBuildPlan.{target, product}MaptoIdentifiableSet<{Product, Module}BuildDescription.Result:
BuildTripleis no longer used for build related operations such as planning and forming llbuild manifests.