[Build] BuildPlan: Use Destination instead of BuildTriple to form…
#7881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… per-module plugin output directory Remove one of the last places where `BuildTriple` was still used. This is an NFC since there are no observable differences here from user perspective, just a different mechanism is used to get the same information.
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
MaxDesiatov
reviewed
Aug 15, 2024
| @@ -786,7 +788,7 @@ extension BuildPlan { | |||
| components: [ | |||
| package.identity.description, | |||
| module.name, | |||
| module.buildTriple.rawValue, | |||
There was a problem hiding this comment.
Are there any remaining uses of buildTriple or can this property be removed now?
There was a problem hiding this comment.
Yeah, we have a few more uses, mostly tests though. I'm planning to follow-up with SourceKitLSPAPI PR and then a PR to remove the rest.
MaxDesiatov
approved these changes
Aug 16, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… per-module plugin output directory
Motivation:
This is an NFC since there are no observable differences here from user perspective, just a different mechanism is used to get the same information.
Modifications:
computeDestinationsprovides a destination that should be used to invoke build tool plugins per module.Result:
Removes one of the last places where
BuildTriplewas still used.