Fix InternalImportsByDefault diagnostics in _AsyncFileSystem
#7895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
owenv
approved these changes
Aug 20, 2024
|
There is a possibility the self-hosted jobs may not recognize these features as "upcoming", let's see... |
|
Yeah, this isn't going to work because of the self hosted jobs (which are still 5.9). We could wrap them in |
|
Ok, sounds like I should just revert all of the |
Both the `StrictConcurrency` and `InternalImportsByDefault` features became "upcoming" features instead of "experimental" features in the Swift 6 compiler. This means that specifying those features with `.enableExperimentalFeature()` no longer works with newer toolchains, and therefore these settings in SwiftPM's Package.swift have become inactive. I'm making the compiler more lenient, so that `-enable-experimental-feature` will enable the corresponding upcoming feature if relevant (swiftlang/swift#75962) but in the meantime it appears that some of the code in SwiftPM needs some fixes to continue to be accepted by the compiler with these features on.
tshortli
force-pushed
the
upcoming-features
branch
from
1568dcd to
72e65e7
Compare
tshortli
changed the title
.enableUpcomingFeature() for StrictConcurrency and InternalImportsByDefaultInternalImportsByDefault diagnostics in _AsyncFileSystem
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some
InternalImportsByDefaultdiagnostics in the_AsyncFileSystemwhich have crept in because the Swift 6 toolchain isn't enforcing.enableExperimentalFeature("InternalImportsByDefault").Motivation:
Both the
StrictConcurrencyandInternalImportsByDefaultfeatures became "upcoming" features instead of "experimental" features in the Swift 6 compiler. This means that specifying those features with.enableExperimentalFeature()no longer works with newer toolchains, and therefore these settings in SwiftPM'sPackage.swifthave become inactive. I'm making the compiler more lenient, so that-enable-experimental-featurewill enable the corresponding upcoming feature if relevant (swiftlang/swift#75962) but in the meantime it appears that some of the code in SwiftPM needs some fixes to continue to be accepted by the compiler with these features on.Modifications:
Adjusted access level on a number of import statements in files belonging to the
_AsyncFileSystemtarget.Result:
_AsyncFileSystembuilds successfully whenInternalImportsByDefaultis actually enabled with the Swift 6 toolchain.