-
Notifications
You must be signed in to change notification settings - Fork 1.4k
SE-0387: add --toolset
option to build-related subcommands
#8051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
--toolset
option on build-related subcommands--toolset
option on build-related subcommands
--toolset
option on build-related subcommands--toolset
option to build-related subcommands
@swift-ci test |
@swift-ci test |
@swift-ci test |
@swift-ci test windows |
dschaefer2
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
MaxDesiatov
commented
Oct 18, 2024
@swift-ci test |
@swift-ci test windows |
MaxDesiatov
added a commit
to MaxDesiatov/swift-evolution
that referenced
this pull request
Oct 18, 2024
With swiftlang/swift-package-manager#8051 merged, the proposal is fully implemented.
DougGregor
pushed a commit
to swiftlang/swift-evolution
that referenced
this pull request
Oct 21, 2024
With swiftlang/swift-package-manager#8051 merged, the proposal is fully implemented.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
Equivalent to SwiftPM’s `--toolset` option, implemented in swiftlang/swift-package-manager#8051. Fixes swiftlang#2047 rdar://146557424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command-line interface
cross-compilation
enhancement
swift build
Changes impacting `swift build`
swift test
Changes impacting `swift test` tool
test suite
improvements to SwiftPM test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The only feature proposed in SE-0387 that remains unimplemented is the
--toolset
CLI option:Modifications:
Added
toolsetPaths
onLocationOptions
, which passes newcustomToolsets
argument onSwiftSDK.deriveTargetSwiftSDK
. Added corresponding tests.Result:
New
--toolset
option is able to accept toolset JSON files.