-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Revert "Support separate modules for static and dynamic exporting symbols for Windows" #8112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bols for…" This reverts commit f34907c.
@swift-ci please test |
Works around a link-time bug in SwiftPM that appears to have been introduced in swiftlang/swift-package-manager#8049. Works around swiftlang/swift-package-manager#8111 until swiftlang/swift-package-manager#8112 is in the build. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
@swift-ci please test macOS |
@swift-ci please test macOS self hosted |
1 similar comment
@swift-ci please test macOS self hosted |
Hi @dschaefer2 I think that the above self-hosted macos CI is broken: https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4531/
due to what appears to be an xcode/toolchain update on the CI runners: Last passing run: https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4510/ Failing: https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4531/ I cannot directly influence this. Can you look into this? |
Yes, we've been having issues with the MacOS self hosted job which we upgraded to use snapshot builds so we can start using swift-testing, but that was probably a bad idea, so we're working to revert it back to 6.0.2. Sorry about the delays. |
@swift-ci please test macOS self hosted |
OK, this is taking so long I ended up with a better solution. #8117 Closing. |
@dschaefer2 I confirmed the fix in our CI. Thank you! |
Reverts #8049
We are seeing link errors and missing symbols. Reverting to investigate.