Skip to content

Revert "Support separate modules for static and dynamic exporting symbols for Windows" #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dschaefer2
Copy link
Member

Reverts #8049

We are seeing link errors and missing symbols. Reverting to investigate.

@dschaefer2
Copy link
Member Author

@swift-ci please test

@dschaefer2 dschaefer2 enabled auto-merge (squash) November 11, 2024 15:40
grynspan added a commit to swiftlang/swift-testing that referenced this pull request Nov 11, 2024
Works around a link-time bug in SwiftPM that appears to have been
introduced in
swiftlang/swift-package-manager#8049.

Works around
swiftlang/swift-package-manager#8111 until
swiftlang/swift-package-manager#8112 is in the
build.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@dschaefer2
Copy link
Member Author

@swift-ci please test macOS

@dschaefer2
Copy link
Member Author

@swift-ci please test macOS self hosted

1 similar comment
@hjyamauchi
Copy link

@swift-ci please test macOS self hosted

@hjyamauchi
Copy link

Hi @dschaefer2 I think that the above self-hosted macos CI is broken:

https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4531/

     1 | @main
     2 | struct AsyncMain4 {
       |        `- note: add @available attribute to enclosing struct
     3 |   static func main() async {
       |               |      `- error: concurrency is only available in macOS 10.15.0 or newer
       |               `- note: add @available attribute to enclosing static method
     4 |     print(await getGreeting4())
     5 |   }

due to what appears to be an xcode/toolchain update on the CI runners:

Last passing run: https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4510/
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-5.9.2.2.51 clang-1500.1.0.2.2)

Failing: https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4531/
Apple Swift version 6.1-dev (LLVM 5c0d283c37132bf, Swift b5af518638c9a16)

I cannot directly influence this. Can you look into this?

@dschaefer2
Copy link
Member Author

Yes, we've been having issues with the MacOS self hosted job which we upgraded to use snapshot builds so we can start using swift-testing, but that was probably a bad idea, so we're working to revert it back to 6.0.2. Sorry about the delays.

@dschaefer2
Copy link
Member Author

@swift-ci please test macOS self hosted

@dschaefer2
Copy link
Member Author

OK, this is taking so long I ended up with a better solution. #8117

Closing.

@dschaefer2 dschaefer2 closed this Nov 14, 2024
auto-merge was automatically disabled November 14, 2024 01:59

Pull request was closed

@jakepetroules jakepetroules deleted the revert-8049-win.linking branch November 14, 2024 03:52
@hjyamauchi
Copy link

@dschaefer2 I confirmed the fix in our CI. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants