-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Workspace/InitPackage: Add .vscode
to .gitignore
#8164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace/InitPackage: Add .vscode
to .gitignore
#8164
Conversation
@swift-ci test |
.vscode
to .gitignore
I always wondered that. There are somethings in there that could be shared. Given Paul merged it, I'll assume that you are correct :). |
yeah, I now remember it's |
You can add more launch configurations by hand. I do that when running SwiftPM with various options when testing. Also the tasks.json has the build configurations which I sometimes change to add verbosity, etc. Mind you it's a problem with VSCode that those things aren't separated out to user and shared like Xcode does. |
I may have been too quick to automerge this. While its true that there are some things in .vscode that you may not want to commit it is still useful to have {settings,tasks,launch,extensions}.json checked in to share configuration with your team. As a result may want more granularity here than just all of .vscode. See this example .gitignore: https://www.toptal.com/developers/gitignore/api/visualstudiocode |
This reverts commit 891f578.
Like @dschaefer2 mentions, you can manually add stuff to In a few projects Swift that I've set up VS Code on, we do share all those files out of necessity. I can see how you might not want to share some of the files, but ... I think you should? I'm not a huge VS Code user so not sure what is the consensus in their community, but sharing these files in a few teams, they have only been helpful. For example when sharing Using |
Motivation:
When using VS Code, this directory gets created, but generally isn't meant to be checked in, similar to Xcode' xcuserdata.
Modifications:
Added .vscode to the generated .gitignore for new packages.
Result:
When creating a new package, when an adopter uses VS Code, they won't have to add this entry into their .gitignore by hand.