Sever the package dependency if using SwiftBuild Framework #8434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SwiftBuild project has a dependency on Swift Driver, which has a dependency on Swift Tools Support Core (STSC). Swift Package Manager (SwiftPM) executable targets also have a dependency on STSC. Sever SwiftPM package depenedency on STSC if the SWIFTPM_SWBUILD_FRAMEWORK environment variable is set so we can indirectly pull the STCS dependency on the dynamic libray that will be pulled in via SwiftDriver.
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
|
@swift-ci please test self hosted windows |
jakepetroules
approved these changes
Apr 1, 2025
MaxDesiatov
reviewed
Apr 1, 2025
Comment on lines
+90
to
+93
| private func useSwiftBuildPackageDependency() -> Bool { | ||
| return (ProcessInfo.processInfo.environment["SWIFTPM_SWBUILD_FRAMEWORK"] == nil && | ||
| ProcessInfo.processInfo.environment["SWIFTPM_NO_SWBUILD_DEPENDENCY"] == nil) | ||
| } |
There was a problem hiding this comment.
Is there a particular reason this uses a function instead of a simple let binding? I also don't think private is needed here, there's no chance this function could be used accidentally elsewhere, since multi-file package manifest is not a thing.
There was a problem hiding this comment.
This is used in two places, so instead of duplicating the logic, I opted to put it in a function call.
There was a problem hiding this comment.
But is there a need to duplicate the logic with a let binding? With a function the computation is duplicated since the function is invoked twice, while with a let binding it would be computed only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SwiftBuild project has a dependency on Swift Driver, which has a dependency on Swift Tools Support Core (STSC). Swift Package Manager (SwiftPM) executable targets also have a dependency on STSC.
Sever SwiftPM package depenedency on STSC if the
SWIFTPM_SWBUILD_FRAMEWORKenvironment variable is set so we can indirectly pull the STCS dependency on the dynamic library that will be pulled in via SwiftDriver.